Re: [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse()

[Adrian Bunk]

On Fri, Nov 17, 2006 at 11:54:04AM -0800, Andrew Morton wrote:
> On Fri, 17 Nov 2006 15:21:45 +0100
> Adrian Bunk <bunk@xxxxxxxxx> wrote:
> 
> > This patch removes the no longer used pci_find_device_reverse().
> 
> But it is exported to modules.
> 
> This is what we created EXPORT_UNUSED_SYMBOL() for.

The fact that noone uses it (except for the 8 symbols I marked in June) 
might be a good indication that it doesn't fit into the current kernel 
development model:
- there is no stable kernel API and
- we lack a strict process for reviewing _every single_ newly added
  export - especially the many that get added without any in-kernel user

And if you'd take your EXPORT_UNUSED_SYMBOL() serious, any changes to 
the signatures of exported functions had to be strictly forbidden.

Please do either make strong promises about the API for external modules 
with all consequences or allow all API changes immediately.

But you currently allowing API changes at any time while putting high 
obstacles for my cleanup patches to remove code with zero in-kernel 
users is very close to a personal offense.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/