Re: [patch 2/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

[Russell King]

On Fri, Nov 17, 2006 at 09:02:10AM -0400, Anderson Briglia wrote:
> @@ -366,15 +434,33 @@ static int __init mmc_init(void)
>  	if (ret == 0) {
>  		ret = class_register(&mmc_host_class);
>  		if (ret)
> -			bus_unregister(&mmc_bus_type);
> +			goto error;
> +	}
> +#ifdef	CONFIG_MMC_PASSWORDS
> +	else {
> +		ret = register_key_type(&mmc_key_type);
> +		if (ret)
> +			goto error_mmc_pwd;

This is obviously untested - you won't get to register the key type if
bus_register() succeeds.  You actually only register it if bus_register()
fails.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/