RE: [PATCH 2.6.19-rc5-mm2] cpufreq: set policy->curfreq on initialization

From: Pallipadi, Venkatesh
Date: Fri Nov 17 2006 - 09:02:06 EST



Acked.
Andrew: Please include this patch in mm.

Thanks,
Venki

>-----Original Message-----
>From: Mattia Dongili [mailto:malattia@xxxxxxxx]
>Sent: Wednesday, November 15, 2006 11:05 AM
>To: Pallipadi, Venkatesh; ego@xxxxxxxxxx; Reuben Farrelly;
>Andrew Morton; davej@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>CPUFreq Mailing List; Sadykov, Denis M
>Subject: [PATCH 2.6.19-rc5-mm2] cpufreq: set policy->curfreq
>on initialization
>
>
>Check the correct variable and set policy->cur upon acpi-cpufreq
>initialization to allow the userspace governor to be used as default.
>
>Signed-off-by: Mattia Dongili <malattia@xxxxxxxx>
>
>---
>
>Reuben, could you also try if this patch fixes the BUG()?
>Thanks
>
>diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>index 18f4715..a630f94 100644
>--- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>+++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>@@ -699,14 +699,14 @@ static int acpi_cpufreq_cpu_init(struct
> if (result)
> goto err_freqfree;
>
>- switch (data->cpu_feature) {
>+ switch (perf->control_register.space_id) {
> case ACPI_ADR_SPACE_SYSTEM_IO:
> /* Current speed is unknown and not detectable
>by IO port */
> policy->cur = acpi_cpufreq_guess_freq(data,
>policy->cpu);
> break;
> case ACPI_ADR_SPACE_FIXED_HARDWARE:
> acpi_cpufreq_driver.get = get_cur_freq_on_cpu;
>- get_cur_freq_on_cpu(cpu);
>+ policy->cur = get_cur_freq_on_cpu(cpu);
> break;
> default:
> break;
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/