Re: [patch, -rc6] x86_64: UP build fixes

[Ingo Molnar]

* Andi Kleen <ak@xxxxxxx> wrote:

> > my hotplug-CPU cleanup patch solves this in a cleaner way: by 
> > removing all those #ifdefs as well.
> 
> Fine, but I suspect that late in the release it's better to go for 
> minimal "obvious" fixes. Later it can then be cleaned up properly.

we are not /that/ late to not apply trivial cleanups. If my patch breaks 
anything then it's easy enough to fix it. But 'lets clean this up later' 
is bound to be forgotten and puts the onus on the person doing the 
cleanups. You yourself have sent more complex partly-cleanup patches 
upstream just 2 days ago:

[PATCH for 2.6.19] [8/9] x86_64: Fix vgetcpu when CONFIG_HOTPLUG_CPU is disabled

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/