Re: [PATCH] sbp2: make 1bit bitfield unsigned

From: Mariusz Kozlowski
Date: Wed Nov 15 2006 - 18:04:46 EST


Hello,

> Luca Tettamanti wrote:
> > A signed single-bit bitfield doesn't make much sense. Make it unsigned.
> ...
> Committed to linux1394-2.6.git.

There is a few more. Hopefuly 'grep + my eyes' caught them all.
The patch is against 2.6.19-rc5-mm2.

Signed-of-by: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>

diff -upr linux-2.6.19-rc5-mm2-a/drivers/isdn/hisax/isdnhdlc.h linux-2.6.19-rc5-mm2-b/drivers/isdn/hisax/isdnhdlc.h
--- linux-2.6.19-rc5-mm2-a/drivers/isdn/hisax/isdnhdlc.h 2006-11-15 11:24:19.000000000 +0100
+++ linux-2.6.19-rc5-mm2-b/drivers/isdn/hisax/isdnhdlc.h 2006-11-15 23:54:15.000000000 +0100
@@ -41,10 +41,10 @@ struct isdnhdlc_vars {
unsigned char shift_reg;
unsigned char ffvalue;

- int data_received:1; // set if transferring data
- int dchannel:1; // set if D channel (send idle instead of flags)
- int do_adapt56:1; // set if 56K adaptation
- int do_closing:1; // set if in closing phase (need to send CRC + flag
+ unsigned int data_received:1; // set if transferring data
+ unsigned int dchannel:1; // set if D channel (send idle instead of flags)
+ unsigned int do_adapt56:1; // set if 56K adaptation
+ unsigned int do_closing:1; // set if in closing phase (need to send CRC + flag
};


diff -upr linux-2.6.19-rc5-mm2-a/drivers/media/dvb/frontends/l64781.c linux-2.6.19-rc5-mm2-b/drivers/media/dvb/frontends/l64781.c
--- linux-2.6.19-rc5-mm2-a/drivers/media/dvb/frontends/l64781.c 2006-11-08 03:24:20.000000000 +0100
+++ linux-2.6.19-rc5-mm2-b/drivers/media/dvb/frontends/l64781.c 2006-11-15 21:35:33.000000000 +0100
@@ -36,7 +36,7 @@ struct l64781_state {
struct dvb_frontend frontend;

/* private demodulator data */
- int first:1;
+ unsigned int first:1;
};

#define dprintk(args...) \
diff -upr linux-2.6.19-rc5-mm2-a/sound/arm/sa11xx-uda1341.c linux-2.6.19-rc5-mm2-b/sound/arm/sa11xx-uda1341.c
--- linux-2.6.19-rc5-mm2-a/sound/arm/sa11xx-uda1341.c 2006-11-08 03:24:20.000000000 +0100
+++ linux-2.6.19-rc5-mm2-b/sound/arm/sa11xx-uda1341.c 2006-11-15 21:40:16.000000000 +0100
@@ -125,7 +125,7 @@ struct audio_stream {
#else
dma_regs_t *dma_regs; /* points to our DMA registers */
#endif
- int active:1; /* we are using this stream for transfer now */
+ unsigned int active:1; /* we are using this stream for transfer now */
int period; /* current transfer period */
int periods; /* current count of periods registerd in the DMA engine */
int tx_spin; /* are we recoding - flag used to do DMA trans. for sync */


--
Regards,

Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/