Re: Yet another borken page_count() check ininvalidate_inode_pages2()....

From: Trond Myklebust
Date: Wed Nov 15 2006 - 15:58:23 EST


On Wed, 2006-11-15 at 11:24 -0800, Andrew Morton wrote:

> The protocol is
>
> lock_page()
> set_page_writeback()
> ->writepage()

We're not using ->writepage().

> and there are various places which assume that nobody will start new
> writeout of a locked page. But I forget where they are - things have always
> been this way.

Huh? There has never been a requirement to lock the page if all you want
to do is call set_page_writeback(). The only reason why we want to do
that at all is to allow the VM to track that the page is under I/O. All
other operations involved in scheduling writes are protected by internal
NFS locks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/