Re: [PATCH] i386-pda UP optimization

[Jeremy Fitzhardinge]

Ingo Molnar wrote:
> Eric's test shows a 5% slowdown. That's far from cheap.
>   

It seems like an absurdly large difference.  PDA references aren't all
that common in the kernel; for the %gs prefix on PDA accesses to be
causing a 5% overall difference in a test like this means that the
prefixes would have to be costing hundreds or thousands of cycles, which
seems absurd.  Particularly since Eric's patch doesn't touch head.S, so
the %gs save/restore is still being executed.

Are we sure this isn't a cache layout issue?  Eric, did you try evicting
your executable from pagecache between runs to see if you get variation
depending on what physical pages it gets put into?  (Making several
copies of the executable should have the same effect.)

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/