Re: [PATCH 2/2] Use dev_sysdata for ACPI and remove firmware_data

From: Benjamin Herrenschmidt
Date: Tue Nov 14 2006 - 00:51:28 EST



> device.firmware_data was born when we went to link Linux devices
> and ACPI devices using device.platform_data and found it was already used.
> You recommended we create a new field to avoid the conflict, and
> IIR the discussion suggested that eventually device.platform_data use
> would get cleaned up and the fields could perhaps some day be combined.
>
> I don't know if we are any closer to that day, before or after this change.

I've audited use of platform data and plan to get rid of it too :-)

(Or actually move it to platform_device where it belongs and fix other
abusers)

> However, I'm fine with Ben's re-name -- it changes no functionality on ACPI-enabled
> systems while potentially deleting an unused pointer/dev on other architectures.
>
> Please ship his patch #2 along with patch #1 that it depends on.
>
> Acked-by: Len Brown <len.brown@xxxxxxxxx>

Excellent, thanks !

Cheers,
Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/