Re: [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X

From: David Miller
Date: Tue Nov 14 2006 - 00:18:32 EST


From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 14 Nov 2006 12:59:54 +1100

> If I "fix" the kernel to do the right thing, that is pass BAR values in
> devices and expect BAR values in mmap, then I will break existing X
> setups on machines where PCI is not mapped 1:1 (that is mostly CHRP
> machines).
>
> The problem I'm fixing in this patch is that while we were providing the
> hacked up value in "devices", we were expecting the BAR value in mmap,
> and there are apps expecting us to be consistent between the two, thus
> the breakage.

Ok, I don't see much alternatives for you then. I have no real
objections to your patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/