Re: [PATCH] Apple Motion Sensor driver

[Dmitry Torokhov]

Hi Stelian,

On 11/11/06, Stelian Pop <stelian@xxxxxxxxxx> wrote:

+
> +       if (input_register_device(ams_info.idev)) {
> +               input_free_device(ams_info.idev);
> +               ams_info.idev = NULL;
> +               return;
> +       }
> +
> +       ams_info.kthread = kthread_run(ams_mouse_kthread, NULL, "kams");
> +       if (IS_ERR(ams_info.kthread)) {
> +               input_unregister_device(ams_info.idev);
> +               ams_info.idev = NULL;
> +               return;
> +       }
> +}

Please consider implementing ams_mouse_start() and ams_mouse_stop()
methods for input_dev and start/stop polling thread there - there is
no reason to report input events when noone listens to them.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/