Re: [patch] genapic: optimize & fix APIC mode setup

From: Ingo Molnar
Date: Mon Nov 13 2006 - 03:17:28 EST



* Andi Kleen <ak@xxxxxxx> wrote:

> Now if it causes device driver issues that's different of course. I
> wasn't aware of this before.

lets try my patch in -mm for a while.

Had i ever noticed this hack in the first place i would have NAK-ed it.
There is a fundamental design friction of a high-level feature like
HOTPLUG_CPU /requiring/ a fundamental change to the lowlevel IRQ
delivery mode! Such a requirement is broken and just serves to hide a
flaw in the hotplug design - which flaw would trigger on i386 /anyway/,
because i386 still uses logical delivery mode for APIC IPIs. Also, i'd
like to have a description of how to reproduce those CPU hotplug
problems, so that i can try to fix it.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/