Re: 2.6.19-rc3 system freezes when ripping with cdparanoia at ioctl(SG_IO)

From: Brice Goglin
Date: Fri Nov 10 2006 - 11:19:42 EST


Jens Axboe wrote:
> On Thu, Nov 09 2006, Monty Montgomery wrote:
>
>> On 11/9/06, Tejun Heo <htejun@xxxxxxxxx> wrote:
>>
>>
>>> drivers/scsi/sg.c interprets SG_DXFER_TO_FROM_DEV as read while
>>> block/scsi_ioctl.c interprets it as write. I guess this is historic
>>> thing (scsi/sg.c updated but block/scsi_ioctl.c is forgotten).
>>>
>> Not historic; Jens accidentally implemented it backwards. No one
>> noticed for a long time. I submitted a patch for this a few months
>> ago.
>>
>
> Yeah, I wonder why that did not go in, I remember the full breadth of
> our discussion and you are fully correct. I'll make sure it gets into
> 2.6.19!
>

Note sure this patch was supposed to fix our freeze, but I just tried on
top of rc5 and it does not seem to fix it.

Brice

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/