Re: [PATCH -mm 3/3][AIO] - AIO completion signal notification

From: Sébastien Dugué
Date: Fri Nov 10 2006 - 04:23:33 EST


On Thu, 2006-11-09 at 11:18 -0800, Badari Pulavarty wrote:
> On Thu, 2006-11-09 at 16:59 +0100, Sébastien Dugué wrote:
>
> > @@ -1549,8 +1657,7 @@ int fastcall io_submit_one(struct kioctx
> > ssize_t ret;
> >
> > /* enforce forwards compatibility on users */
> > - if (unlikely(iocb->aio_reserved1 || iocb->aio_reserved2 ||
> > - iocb->aio_reserved3)) {
> > + if (unlikely(iocb->aio_reserved1)) {
> > pr_debug("EINVAL: io_submit: reserve field set\n");
> > return -EINVAL;
>
> Is there a reason for not checking "aio_reserved3" ?
> You are still not using it. Right ?
>

Yep, forgot this one.

Thanks,

Sébastien.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/