Re: [RFC][PATCH] Fix lock inversion aio_kick_handler()

From: Jeff Moyer
Date: Thu Nov 09 2006 - 17:57:35 EST


==> On Thu, 09 Nov 2006 14:51:59 -0800, Zach Brown <zach.brown@xxxxxxxxxx> said:

Zach> > Zach> > Doh. Unfortunately, this patch isn't entirely correct
Zach> as it > Zach> could race with > __put_ioctx() which sets
Zach> ioctx->mm = NULL.
Zach> >
Zach> > Zach> Aha, yeah, that's what I was missing. Thanks.
Zach> >
Zach> > Zach> > Something like the following should do the trick:
Zach> >
Zach> > Zach> Cool, I'll respin and send it out.
Zach> >
Zach> > Did you ever resend this patch, Zach?

Zach> Sadly, no. I vaguely remember thinking that the refcounting was
Zach> pretty messed up in these paths and that more than just this
Zach> patch was needed. I don't remember the details.

Zach> Maybe I should take a look again :/.

Zach> > current kernels. I'm still running into the lockdep warnings.

Zach> When doing what? Working with that IO_CMD_EPOLL_WAIT patch?

Yep. =)

-Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/