Re: e1000 driver 2.6.18 - how to waste processor cycles

From: Jesse Brandeburg
Date: Thu Nov 09 2006 - 17:46:01 EST


On 11/9/06, Jeffrey V. Merkey <jmerkey@xxxxxxxxxxxxxxxxxx> wrote:
In the case I am referring to, the memory is already mapped with a
previous call, which means it may be getting
mapped twice.

I guess maybe I'm not keeping up with you. This is what I see looking
in 2.6.18, i see e1000_clean_rx_irq:

check done bit
pci_unmap_single
copybreak and recycle
OR
hand buffer up stack

the only branch before the unmap is the napi break out, and in that
case we don't change any memory state, so alloc will not do anything.

As for alloc rx, we always map, because we always unmapped.

Did I miss something? I would appreciate a more detailed explanation
of what you see going wrong.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/