Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos

From: Valdis . Kletnieks
Date: Wed Nov 08 2006 - 23:51:06 EST


On Wed, 08 Nov 2006 16:15:46 CST, Corey Minyard said:
> Ouch, I guess we've never had a system with these address types. Thanks.

If we never had a system with these address types..

> > static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
> > {
> > return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
> > - && 0xff;
> > + & 0xff;
> > }

Is this dead code that isn't called by anybody?

Attachment: pgp00000.pgp
Description: PGP signature