Re: [PATCH] gx-suspmod: fix "&& 0xff" typo

From: Dave Jones
Date: Wed Nov 08 2006 - 17:11:35 EST


On Thu, Nov 09, 2006 at 01:04:35AM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
>
> arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> +++ b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> @@ -473,7 +473,7 @@ static int __init cpufreq_gx_init(void)
> pci_read_config_byte(params->cs55x0, PCI_MODON, &(params->on_duration));
> pci_read_config_byte(params->cs55x0, PCI_MODOFF, &(params->off_duration));
> pci_read_config_dword(params->cs55x0, PCI_CLASS_REVISION, &class_rev);
> - params->pci_rev = class_rev && 0xff;
> + params->pci_rev = class_rev & 0xff;
>
> if ((ret = cpufreq_register_driver(&gx_suspmod_driver))) {
> kfree(params);

Ouch, good catch. applied.

Dave

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/