Re: + i386-lapic-timer-calibration.patch added to -mm tree

From: Thomas Gleixner
Date: Wed Nov 08 2006 - 07:25:42 EST


On Wed, 2006-11-08 at 13:09 +0100, Ingo Molnar wrote:
> one question:
>
> > + long tapic = apic_read(APIC_TMCCT);
> > + unsigned long pm = acpi_pm_read_early();
>
> is this function call safe if the box has no pm-timer?

That's in the pm-timer-allow-early-access.patch:

Subject: pmtimer: Allow early access to pm timer

+static inline u32 acpi_pm_read_early(void)
+{
+ if (!pmtmr_ioport)
+ return 0;
+ /* mask the output to 24 bits */
+ return acpi_pm_read_verified();
+}

If pmtmr is not available, the function returns 0, so the resulting
delta is 0 and therefor ignored. Same applies, when PMTIMER is disabled
in the config.

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/