Re: [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability

[Jörn Engel]

On Tue, 7 November 2006 10:56:06 -0500, Jeff Layton wrote:
> 
> Here's a more involved (again, untested) patch. I turned new_inode into
> a wrapper for a new function (new_inode_autonum). If the autonum arg is
> set, then we should get back a unique i_ino.

A good start.  You didn't convert any callers yet, so I did a quick
poll.  Turned out that out of 76 callers 37 explicitly set i_ino, 1
(fat) calls iunique itself and 38 look at first glance as if they
didn't set i_ino.  xfs and jfs were in the latter category, which just
proved I didn't look too closely.

Anyway, the distribution is fairly even, so I agree with your choice
of default behaviour.

JÃrn

-- 
Schrödinger's cat is <BLINK>not</BLINK> dead.
-- Illiad
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/