Re: + net-uninline-xfrm_selector_match.patch added to -mm tree

[Andrew Morton]

On Mon, 06 Nov 2006 14:38:31 -0800 (PST)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: akpm@xxxxxxxx
> Date: Fri, 03 Nov 2006 11:34:12 -0800
> 
> > Subject: net: uninline xfrm_selector_match()
> > From: Andrew Morton <akpm@xxxxxxxx>
> > 
> > Six callsites, huge.
> > 
> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
> 
> You can't implement it like this :-)
> 
> xfrm_user.c is a bad place to put the uninlined version because
> this can be built modular, whereas the callsites in places such
> as xfrm_policy.c will be built statically into the kernel.

I would have found that out when I got around to compiling it ;)

Where should the out-of-line function be placed, or should I just drop it? 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/