Re: [PATCH] e1000: Fix regression: garbled stats and irq allocationduring swsusp

[Auke Kok]

Jeff Garzik wrote:
> Auke Kok wrote:
> > e1000: Fix regression: garbled stats and irq allocation during swsusp
> >
> > After 7.0.33/2.6.16, e1000 suspend/resume left the user with an enabled
> > device showing garbled statistics and undetermined irq allocation state,
> > where `ifconfig eth0 down` would display `trying to free already freed 
> > irq`.
> >
> > Explicitly free and allocate irq as well as powerup the PHY during resume
> > fixes.
> >
> > Signed-off-by: Auke Kok <auke-jan.h.kok@xxxxxxxxx>
>
> ACK, but:
>
> Applying 'e1000: Fix regression: garbled stats and irq allocation during 
> swsusp'
>
> fatal: corrupt patch at line 8


There's another problem with it, that needs attention as well. I will reformat and 
re-post the patch to everyone.

Cheers,

Auke


From: <chrisw@xxxxxxxxxxxx>
Also, would this cause a problem if I ifdown the interface to call
->close then suspend?  Looks like it'd free_irq twice, maybe need a
netif_running() check?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/