Re: ipc/msg.c "cleanup" breaks fakeroot on Alpha

[Ingo Molnar]

* Falk Hueffner <falk@xxxxxxxxxx> wrote:

> -	struct msg_msg* volatile r_msg;
> +	volatile struct msg_msg	*r_msg;
>  };
>  
> breaks fakeroot on Alpha (variously hangs or oopses). Backing it out 
> of 2.6.19-rc4 fixes the issue. Is it possible that this change (which 
> clearly does change semantics) was made in error?

correct, it was an error, lets back it out.

Another interesting question is: what in the IPC code relies on the 
volatility of this field, and shouldnt it be converted to explicit 
barriers instead?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/