Re: [PATCH 2/3] fsstack: Generic get/set lower object functions

From: Jan Engelhardt
Date: Fri Nov 03 2006 - 11:50:45 EST



>> Why? What is so special about the details that you need to hide them?
>> This is a union that will always be part of a structure anyway.
>
> Nothing. Josef, I think we should make them unions.

In other words,

/* structs to maintain pointers to the lower VFS objects */
struct fsstack_sb_info {
union {
struct super_block *sb;
struct super_block **sbs;
};
};

should become:

union fsstack_sb_info {
struct super_block *sb;
struct super_block **sbs;
};


-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/