Re: [PATCH] Fix user.* xattr permission check for sticky dirs

[Andreas Gruenbacher]

On Friday 03 November 2006 05:57, Timothy Shimmin wrote:
> > so this added the check to the xfs_getxattr() path by accident:
> >
> > []	if (!S_ISREG(inode->i_mode) &&
> > []	    (!S_ISDIR(inode->i_mode) || inode->i_mode & S_ISVTX))
> > []		return -EPERM;
>
> Now, I'm a bit confused.
> xfs_getxattr?
> I see the "correct" version of the test in xfs_attr.c/attr_user_capable().

I meant to say fs/xattr.c:vfs_getxattr() and fs/xattr.c:vfs_setxattr(), sorry. 
The xfs code is fine, it just contains the same check once again in 
fs/xfs/xfs_attr.c:attr_user_capable().

Thanks,
Andreas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/