Re: [RFC, PATCH] dont insert sockets/pipes dentries into dentry_hashtable.

From: Al Viro
Date: Wed Nov 01 2006 - 03:42:58 EST


On Wed, Nov 01, 2006 at 08:38:11AM +0000, Al Viro wrote:
> On Wed, Nov 01, 2006 at 09:21:06AM +0100, Eric Dumazet wrote:
>
> > And " (deleted)" is correctly added to deleted files.
>
> The hell it will.
>
> touch a
> touch b
> exec 5<a
> mv b a
> ls -l /proc/$$/fd/5
>
> With your patch and without it, please.

While we are at it,

touch a
rm a
touch a
ls -l /proc/self/fd/0 <a

With and without your patch. Note that you never remove DCACHE_DELETED
after you've set it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/