Re: [PATCH 9/13] KVM: define exit handlers

From: Anthony Liguori
Date: Mon Oct 23 2006 - 21:05:52 EST


Avi Kivity wrote:
+static int handle_external_interrupt(struct kvm_vcpu *vcpu,
+ struct kvm_run *kvm_run)
+{
+ ++kvm_stat.irq_exits;
+ return 1;
+}

Don't you need to propagate the interrupt here? In Xen, we inject the interrupt using the IDT. As a module, you don't have access to that. However, you could use a software interrupt to reraise it.

I got your code running this afternoon (it's quite cool) but I noticed a ton of "rtc: lost some interrupts at 1024Hz." messages which leads me to believe.. you're dropping interrupts :-) Things seem to hang trying to bring up eth0 in the guest.

BTW, have you setup a mailing list yet?

Regards,

Anthony Liguori
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/