Re: [PATCH 2.6.19-rc2] [REVISED] net/ipv4/multipath_wrandom.c: checkkmalloc() return value.

From: James Morris
Date: Mon Oct 23 2006 - 03:46:52 EST


On Sun, 22 Oct 2006, Amit Choudhary wrote:

> Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c.
>
> Signed-off-by: Amit Choudhary <amit2030@xxxxxxxxx>

Acked-by: James Morris <jmorris@xxxxxxxxx>

> @@ -242,6 +242,9 @@ static void wrandom_set_nhinfo(__be32 ne
> target_route = (struct multipath_route *)
> kmalloc(size_rt, GFP_ATOMIC);

It'd be nice to see these casts removed in a future cleanup.



- James
--
James Morris
<jmorris@xxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/