Re: [PATCH] lockdep: fix ide/proc interaction

[Jarek Poplawski]

On Thu, Oct 19, 2006 at 01:05:56PM +0200, Peter Zijlstra wrote:
> On Thu, 2006-10-19 at 10:40 +0200, Jarek Poplawski wrote:
...
> > But now:
> > >  (proc_subdir_lock){--..}, at: [<c04a33b0>] remove_proc_entry+0x40/0x191
> > 
> > is taken here with irqs and bhs enabled (btw. this: {--..} looks
> > as if it wasn't called from here with spin_lock_irqsave?) 
> > IMHO it is hard to believe this lock isn't anywhere used in
> > hard or soft irq context so probably local_irq_disable/enable
> > or local_bh_disable/enable is needed around this.
> 
> it really isnt, check fs/proc/{generic,proc_devtree}.c

I did it - but I hope all places were checked and 
remove_proc_entry (or other with proc_subdir_lock)
is not used by any timer etc. 

Sorry for false alarm,

Regards,

Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/