Re: [PATCH] OOM killer meets userspace headers

From: Alexey Dobriyan
Date: Wed Oct 18 2006 - 14:47:23 EST


On Thu, Oct 19, 2006 at 01:05:53AM +1000, Nick Piggin wrote:
> >+#define OOM_ADJUST_MIN (-16)
> >+#define OOM_ADJUST_MAX 15
>
> Why do you need the () for the -ves?

-16 is two tokens. Not that someone is going to do huge arithmetic with
OOM adjustments and screwup himself, but still...
15 is one token, so it's safe.

And if someone from kernel-janitors would go through tree and (without
fanatism) add additional parenthesis to where they belong, it would be
nice.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/