Re: [PATCH 0/5] Allow more than PAGESIZE data read in configfs

[Joel Becker]

On Sat, Oct 14, 2006 at 12:43:51PM -0700, Andrew Morton wrote:
> On Sat, 14 Oct 2006 01:01:07 -0700
> Greg KH <greg@xxxxxxxxx> wrote:
> > Argh!!!!
> > 
> > Are you going to honestly tell me you have a single attribute in sysfs
> > that is larger than PAGE_SIZE?
> 
> He does not.  It's a matter of reusing existing facilities rather than
> impementing similar things in multiple places.  The equivalent patch in
> configfs removed a decent amount of code:

	Issues of PAGE_SIZE and attribute size aside, the patch posted
was incorrect.  While they used seq_file, they implemented it in a
completely inefficent fashion, filling the entire buffer in one ->show()
call rather than letting multiple read(2) calls iterate their list.

Joel

-- 

"Anything that is too stupid to be spoken is sung."  
        - Voltaire

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@xxxxxxxxxx
Phone: (650) 506-8127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/