Re: [linux-pm] Bug in PCI core

[Benjamin Herrenschmidt]

On Wed, 2006-10-11 at 16:41 -0400, Alan Stern wrote:
> When a PCI device is suspended, its driver calls pci_save_state() so that
> the config space can be restored when the device is resumed.  Then the
> driver calls pci_set_power_state().
> 
> However pci_set_power_state() calls pci_block_user_cfg_access(), and that 
> routine calls pci_save_state() again.  This overwrites the saved state 
> with data in which memory, I/O, and bus master accesses are disabled.  As 
> a result, when the device is resumed it doesn't work.
> 
> Obviously pci_block_user_cfg_access() needs to be fixed.  I don't know the 
> right way to fix it; hopefully somebody else does.

Well, blocking user cfg access snapshots the config space to be able to
respond to user space while the device is offline. Maybe it should be
done from a separate config space image buffer ? ugh....

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/