Re: [patch 0/2] Introduce round_jiffies() to save spurious wakeups

From: Christoph Hellwig
Date: Thu Oct 12 2006 - 15:03:16 EST


On Wed, Oct 11, 2006 at 07:54:57PM +0200, Arjan van de Ven wrote:
> > > An alternative would have been to introduce mod_timer_rounded() or
> > > somesuch APIs (but there's many variants that take jiffies); I feel that
> > > an explicit caller based rounding actually is quite reasonable.
> >
> > I think the API you proposed is horrible. Having jiffies exposed in
> > ani API is a mistake, and adding more makes this problem worse.
>
> and other people like Linus disagree with you.

The only argument from Linus was about getting rid of jiffies completly.
He certainly didn't complain when we added interfaces to reduce jiffies
use in the past (e.g. the msleep APIs)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/