misused local_irq_disable() in analog.c?

From: Alexey Dobriyan
Date: Wed Oct 11 2006 - 15:10:10 EST


Dmitry, take a look at analog_cooked_read():

do-while loop there contains local_irq_disable()/local_irq_restore(flags);
which aren't complement.

Should it be

local_irq_save(flags);
this = gameport_read(gameport) & port->mask;
GET_TIME(now);
local_irq_restore(flags);

?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/