Re: [PATCH] SCSI: minor bug fixes and cleanups

[Rolf Eike Beer]

Jeff Garzik wrote:
> BusLogic: use kzalloc(), remove cast to/from void*
>
> aic7xxx_old: fix typo in cast
>
> NCR53c406a: ifdef out static built code
>
> fd_mcs: ifdef out static built code
>
> ncr53c8xx: ifdef out static built code
>
> Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx>
>
> ---
>
>  drivers/scsi/BusLogic.c       |   12 ++++++------
>  drivers/scsi/NCR53c406a.c     |    5 +++++
>  drivers/scsi/aic7xxx_old.c    |    2 +-
>  drivers/scsi/fd_mcs.c         |    2 ++
>  drivers/scsi/ncr53c8xx.c      |   19 +++++++++++--------
>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index 7c59bba..689dc4c 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2186,21 +2186,21 @@ #endif
>
>  	if (BusLogic_ProbeOptions.NoProbe)
>  		return -ENODEV;
> -	BusLogic_ProbeInfoList = (struct BusLogic_ProbeInfo *)
> -	    kmalloc(BusLogic_MaxHostAdapters * sizeof(struct BusLogic_ProbeInfo),
> GFP_ATOMIC); +	BusLogic_ProbeInfoList =
> +	    kzalloc(BusLogic_MaxHostAdapters * sizeof(struct BusLogic_ProbeInfo),
> GFP_KERNEL); if (BusLogic_ProbeInfoList == NULL) {
>  		BusLogic_Error("BusLogic: Unable to allocate Probe Info List\n", NULL);
>  		return -ENOMEM;
>  	}
> -	memset(BusLogic_ProbeInfoList, 0, BusLogic_MaxHostAdapters *
> sizeof(struct BusLogic_ProbeInfo));

kcalloc

Eike

Attachment: pgp00000.pgp
Description: PGP signature