Re: 2.6.18 suspend regression on Intel Macs

From: Frédéric Riss
Date: Tue Oct 10 2006 - 15:08:43 EST


Le mardi 10 octobre 2006 Ã 08:33 -0700, Linus Torvalds a Ãcrit :
> > If we do this we probably should at least key this of some DMI
> > identification for the mac mini..
>
> No. That would be silly.
>
> Having _conditional_ code is not only bigger, it's orders of magnitude
> more complex and likely to break. It's much better to say: "We know at
> least one machine needs this" than it is to say "We know machine X needs
> this", because the latter has extra complexity that just doesn't buy you
> anything.
>
> It's much better to treat everybody the same, if that works. That way, you
> don't have different code-paths.

So what's the plan? Should/Will the ACPI guys remove the bit-preserving
change brought in with the latest ACPICA merge?

Fred.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/