Re: [PATCH] preserve correct battery state through suspend/resume cycles

[Rafael J. Wysocki]

On Tuesday, 10 October 2006 14:10, Stefan Seyfried wrote:
> On Tue, Oct 10, 2006 at 12:52:09AM +0200, Rafael J. Wysocki wrote:
> > On Sunday, 8 October 2006 20:42, Pavel Machek wrote:
>  
> > > > echo "platform" > /sys/power/disk
> > > > echo "disk" > /sys/power/state
> > > 
> > > Maybe we should change the default in 2.6.20 or so?
> > 
> > Well, I think swsusp should work with "shutdown" just as well.  If it doesn't,
> > that means there are some bugs in the ACPI code which should be fixed.
> > By using "platform" as the default method we'll be hiding those bugs IMHO.
> 
> I'm not really intimately familiar with the ACPI spec, but IIRC those AML
> methods executed by pm_ops->prepare and pm_ops->finish are mandatory for
> suspending ACPI enabled machines. So using "platform" as a default seems
> reasonable (assuming that on non-ACPI machines, pm_ops->{prepare,finish} will
> be a noop anyway)

Well, what swsusp does is not really a suspend operation.  It is, roughly, a
"save the contents of memory and power off" thing.  During the "resume" we do
something like "restore the contents of memory and use it as the initial
data", but the state of devices (ie. hardware) is not expected to be saved.

Moreover, I'm starting to think that it's actually wrong to assume that the
hardware state will be saved and the drivers that make such an assumption
need fixing.


-- 
You never change things by fighting the existing reality.
		R. Buckminster Fuller
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/