Re: [patch 3/3] mm: fault handler to replace nopage and populate

From: Thomas Hellstrom
Date: Tue Oct 10 2006 - 04:41:34 EST


Benjamin Herrenschmidt wrote:
Still, even with NOPAGE_REFAULT or the equivalent with the new fault() code,
in the case we need to take this route, (and it looks like we won't have to),
I guess we still need to restart from find_vma() in the fault()/nopage() handler to make sure the VMA is still present. The object mutex need to be dropped as well to avoid deadlocks. Sounds complicated.


But as we said, it should be enough to do the flag change with the
object mutex held as long as it's after unmap_mapped_ranges()

Ben.


Agreed.
/Thomas



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/