Re: [PATCH 04/10] -mm: clocksource: add some new API calls

From: john stultz
Date: Mon Oct 09 2006 - 15:04:40 EST


On Fri, 2006-10-06 at 11:54 -0700, Daniel Walker wrote:
> plain text document attachment (clocksource_user_api.patch)
> originally used plist but removed it in this patch, and used a sorted list
> which is just as fast with a lot less memory overhead.
>
> Introduces some new API calls,
>
> - clocksource_get_clock()
> Allows a clock lookup by name.
> - clocksource_rating_change()
> Used by a clocksource to signal a rating change. Replaces
> reselect_clocksource()

Adds ns2cyc interface. Just to keep things in logical chunks, maybe
would that chunk be better added with the patch that uses it?

> I also moved the the clock source list to a plist, which removes some lookup
> overhead in the average case.

Probably need to update the header, as you don't use a plist now. :)


> Signed-Off-By: Daniel Walker <dwalker@xxxxxxxxxx>


Otherwise this patch looks like a good cleanup to me.

Acked-by: John Stultz <johnstul@xxxxxxxxxx>

thanks
-john




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/