Re: [PATCH 2.6.19-git] Fix error handling in create_files()

[Luca Tettamanti]

Il Mon, Oct 09, 2006 at 09:48:20AM -0700, Greg KH ha scritto: 
> On Mon, Oct 09, 2006 at 06:40:17PM +0200, Luca Tettamanti wrote:
> > Hello,
> > current code in create_files() detects an error iff the last
> > sysfs_add_file fails:
> > 
> > for (attr = grp->attrs; *attr && !error; attr++) {
> >         error = sysfs_add_file(dir, *attr, SYSFS_KOBJ_ATTR);
> > }
> > if (error)
> >         remove_files(dir,grp);
> > 
> > In order to do the proper cleanup upon failure 'error' must be checked on
> > every iteration.
> 
> But it is, look up there in the "!error" test, right?

Ah, right. I totally missed it.

While we are at it: is it safe to always call sysfs_remove_group even if
the preceding sysfs_create_group failed?

(I'm looking at this warning:

arch/i386/kernel/cpu/mcheck/therm_throt.c: In function 'thermal_throttle_add_dev':
arch/i386/kernel/cpu/mcheck/therm_throt.c:115: warning: ignoring return value of
        'sysfs_create_group', declared with attribute warn_unused_result
)

Luca
-- 
42
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/