[PATCH] driver core: warn unused return value for internal functions

From: Akinobu Mita
Date: Mon Oct 09 2006 - 05:13:29 EST


This patch adds __must_check attribute to driver core internal functions
(drivers/base/base.h)

Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>

drivers/base/base.h | 31 ++++++++++++++++---------------
1 file changed, 16 insertions(+), 15 deletions(-)

Index: work-fault-inject/drivers/base/base.h
===================================================================
--- work-fault-inject.orig/drivers/base/base.h 2006-10-09 15:06:23.000000000 +0900
+++ work-fault-inject/drivers/base/base.h 2006-10-09 15:09:30.000000000 +0900
@@ -1,35 +1,36 @@
+#include <linux/compiler.h>

/* initialisation functions */

-extern int devices_init(void);
-extern int buses_init(void);
-extern int classes_init(void);
-extern int firmware_init(void);
+extern int __must_check devices_init(void);
+extern int __must_check buses_init(void);
+extern int __must_check classes_init(void);
+extern int __must_check firmware_init(void);
#ifdef CONFIG_SYS_HYPERVISOR
-extern int hypervisor_init(void);
+extern int __must_check hypervisor_init(void);
#else
static inline int hypervisor_init(void) { return 0; }
#endif
-extern int platform_bus_init(void);
-extern int system_bus_init(void);
-extern int cpu_dev_init(void);
-extern int attribute_container_init(void);
+extern int __must_check platform_bus_init(void);
+extern int __must_check system_bus_init(void);
+extern int __must_check cpu_dev_init(void);
+extern int __must_check attribute_container_init(void);

-extern int bus_add_device(struct device * dev);
-extern int bus_attach_device(struct device * dev);
+extern int __must_check bus_add_device(struct device * dev);
+extern int __must_check bus_attach_device(struct device * dev);
extern void bus_remove_device(struct device * dev);
extern struct bus_type *get_bus(struct bus_type * bus);
extern void put_bus(struct bus_type * bus);

-extern int bus_add_driver(struct device_driver *);
+extern int __must_check bus_add_driver(struct device_driver *);
extern void bus_remove_driver(struct device_driver *);

extern void driver_detach(struct device_driver * drv);
-extern int driver_probe_device(struct device_driver *, struct device *);
+extern int __must_check driver_probe_device(struct device_driver *, struct device *);

extern void sysdev_shutdown(void);
-extern int sysdev_suspend(pm_message_t state);
-extern int sysdev_resume(void);
+extern int __must_check sysdev_suspend(pm_message_t state);
+extern int __must_check sysdev_resume(void);

static inline struct class_device *to_class_dev(struct kobject *obj)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/