[patch 1/2] sysfs: allow removal of nonexistent sysfs groups.

From: Heiko Carstens
Date: Mon Oct 09 2006 - 03:31:17 EST


From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

This patch makes it safe to call sysfs_remove_group() with a name group
that doesn't exist. Needed to make fix cpu hotplug stuff in topology code.

Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
---
fs/sysfs/group.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6/fs/sysfs/group.c
===================================================================
--- linux-2.6.orig/fs/sysfs/group.c 2006-10-09 09:15:25.000000000 +0200
+++ linux-2.6/fs/sysfs/group.c 2006-10-09 09:25:23.000000000 +0200
@@ -68,9 +68,12 @@
{
struct dentry * dir;

- if (grp->name)
+ if (grp->name) {
+ if (!sysfs_dirent_exist(kobj->dentry->d_fsdata, grp->name))
+ return;
dir = lookup_one_len(grp->name, kobj->dentry,
strlen(grp->name));
+ }
else
dir = dget(kobj->dentry);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/