Re: [PATCH] lockdep-design.txt

[Ingo Molnar]

* Aneesh Kumar <aneesh.kumar@xxxxxxxxx> wrote:

> I was looking at lockdep-desing.txt and i guess i am confused with the 
> changes with respect to fd7bcea35e7efb108c34ee2b3840942a3749cadb. It 
> says
> 
> +   '.'  acquired while irqs enabled
> +   '+'  acquired in irq context
> +   '-'  acquired in process context with irqs disabled
> +   '?'  read-acquired both with irqs enabled and in irq context
> +
> 
> 
> But the get_usage_chars() function does this for '-'
> if (class->usage_mask & LOCKF_ENABLED_HARDIRQS)
>                        *c1 = '-';
> 
> 
> 
> So i guess what would be correct would be
> '.'  acquired while irqs disabled
> '+'  acquired in irq context
> '-'  acquired with irqs enabled
> '?' read acquired in irq context with irqs enabled.
> 
> Is this correct ?

indeed, that's correct.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/