[2.6 patch] drivers/usb/serial/mos7840.c: fix a check-after-dereference

From: Adrian Bunk
Date: Sun Oct 08 2006 - 19:17:30 EST


This patch fixes an obvious check-after-dereference spotted by the
Coverity checker.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6/drivers/usb/serial/mos7840.c.old 2006-10-09 00:35:49.000000000 +0200
+++ linux-2.6/drivers/usb/serial/mos7840.c 2006-10-09 00:36:28.000000000 +0200
@@ -2412,11 +2412,12 @@
}

mos7840_port = mos7840_get_port_private(port);
- tty = mos7840_port->port->tty;

if (mos7840_port == NULL)
return -1;

+ tty = mos7840_port->port->tty;
+
dbg("%s - port %d, cmd = 0x%x", __FUNCTION__, port->number, cmd);

switch (cmd) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/