Re: [PATCH] minimal alpha pt_regs fixes

From: Sam Ravnborg
Date: Sat Oct 07 2006 - 14:27:32 EST


On Sat, Oct 07, 2006 at 11:08:39AM -0400, Jeff Garzik wrote:
> Al Viro wrote:
> >diff --git a/include/asm-alpha/irq_regs.h b/include/asm-alpha/irq_regs.h
> >new file mode 100644
> >index 0000000..3dd9c0b
> >--- /dev/null
> >+++ b/include/asm-alpha/irq_regs.h
> >@@ -0,0 +1 @@
> >+#include <asm-generic/irq_regs.h>
>
>
> ACK, of course, but I wonder if we can do something about these 1-line
> header files.

It would be even more simple and future proof if we could in
some way do it so "#include <foo/bar.h>" would pick up bar.h from
asm-$(ARCH) if it exists and otherwise pick up asm-generic/bar.h.

Then we could include the generic one in asm-generic and
all architectures would include it except those that provide their
own variant. The asm-$(ARCH) specific files would need a way to include
the asm-generic version.

I have no idea handy for how to actually implment this but wanted
just to share the idea.
The trade-off is that if it gets too iplicit then suddenly users will
loose overview of how it works.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/