Re: [PATCH] minimal alpha pt_regs fixes

From: Al Viro
Date: Sat Oct 07 2006 - 11:15:15 EST


On Sat, Oct 07, 2006 at 11:08:39AM -0400, Jeff Garzik wrote:
> Al Viro wrote:
> >diff --git a/include/asm-alpha/irq_regs.h b/include/asm-alpha/irq_regs.h
> >new file mode 100644
> >index 0000000..3dd9c0b
> >--- /dev/null
> >+++ b/include/asm-alpha/irq_regs.h
> >@@ -0,0 +1 @@
> >+#include <asm-generic/irq_regs.h>
>
>
> ACK, of course, but I wonder if we can do something about these 1-line
> header files.
>
> Would it be reasonable to encourage developers to do something like
>
> #ifdef ARCH_HAVE_FEATURE_FOO
> #include <asm/foo.h>
> #else
> #include <asm-generic/foo.h>
> #endif

In something like linux/irq_regs.h? Might make sense...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/