Re: [PATCH 4/5] ioremap balanced with iounmap fordrivers/char/rio/rio_linux.c

From: Alan Cox
Date: Fri Oct 06 2006 - 09:38:03 EST


Ar Gwe, 2006-10-06 am 16:51 +0530, ysgrifennodd Amol Lad:
> > > +
> > > + if (hp->Caddr)
> > > + iounmap(hp->Caddr);
> > > }
> >
> > I don't think this is sufficient because it may be unmapped earlier on
> > error but hp->Caddr is not then cleared .
>
> Is this fine ?
>
> Signed-off-by: Amol Lad <amol@xxxxxxxxxxxxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>

Thanks

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/