Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passingto IRQ handlers

From: Jeff Garzik
Date: Fri Oct 06 2006 - 07:18:08 EST


Alan Cox wrote:
Ar Iau, 2006-10-05 am 20:52 -0400, ysgrifennodd Jeff Garzik:
The overwhelming majority of irq handlers don't use the 'irq' argument either... the driver-supplied pointer is what drivers use, exclusively, to differentiate between different instances.

If we are going to break all the irq handlers, I'd suggest going ahead and removing that one too.

NAK to that, it will mess up a lot of older drivers which still use the
irq field and also those who want it to print

Look at the pt_regs change -- the irq change is similar:

The information does not go away, it is merely available via another avenue.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/