Re: [PATCH 2.6.18 2/2] mmc: Read mmc v4 EXT_CSD

[Pierre Ossman]

Philip Langdale wrote:
> Pierre,
>
> I will reorganise these patches into a series that detects and sets up
> high-speed support. This is pretty simple. Wide-bus is harder because
> you have to run their weird test pattern and check all the power class
> stuff. Hopefully I'll have that done this week.
>   

Goodie. Have these patches seen any wide spread testing?

> Pierre Ossman wrote:
>   
>> philipl@xxxxxxxxx wrote:
>>     
>>> +	list_for_each_entry(card, &host->cards, node) {
>>> +		if (card->state & (MMC_STATE_DEAD|MMC_STATE_PRESENT))
>>> +			continue;
>>>   
>>>       
>> Please use the macros.
>>     
>
> I'm confused: mmc_read_scrs and mmc_read_csds use this exact same
> construction in 2.6.18 and Linus' current tree. Should I be checking
> another tree?
>
>   

Nah, they're also wrong. Patches welcome ;)

Rgds
Pierre

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/