[Patch] Dereference in fs/jbd/journal.c

[Eric Sesterhenn]

hi,

since the commit http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d1807793e1e7e502e3dc047115e9dbc3b50e4534
we dereference a NULL pointer. Coverity id #1432.
We set journal to NULL, and use it directly afterwards.

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>

--- linux-2.6.19-rc1/fs/jbd/journal.c.orig	2006-10-05 12:53:24.000000000 +0200
+++ linux-2.6.19-rc1/fs/jbd/journal.c	2006-10-05 12:53:41.000000000 +0200
@@ -724,7 +724,7 @@ journal_t * journal_init_dev(struct bloc
 		printk(KERN_ERR "%s: Cant allocate bhs for commit thread\n",
 			__FUNCTION__);
 		kfree(journal);
-		journal = NULL;
+		return NULL;
 	}
 	journal->j_dev = bdev;
 	journal->j_fs_dev = fs_dev;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/