Re: [PATCH][RFT] libata AHCI reset speed-up, improvements

[Michael S. Tsirkin]

Quoting Jeff Garzik <jeff@xxxxxxxxxx>:
> Subject: [PATCH][RFT] libata AHCI reset speed-up, improvements
> 
> 
> This patch, diff'd against 2.6.18-git5 (or later), attempts the
> following improvements:
> 
> * Speed up reset, by polling rather than unconditionally sleeping
>   for one seconds.
> * Save the Ports-Implemented register across controller resets.
> * Verify that AHCI mode was truly enabled.
> 
> I'm quite interested in hearing people's test feedback on this patch.
> On my own ICH7 machine, it introduces a "softreset failed" error, but
> EH recovers nicely and nonetheless configures everything successfully.
> Probably just a slow ATAPI device, but I may have exposed a latent
> problem in the driver that was hidden until now by the ssleep(1).

Hi Jeff!
I tested this patch on my T60 (Intel ICH7) 
against git 78b656b8bf933101b42409b4492734b23427bfc3
with the same result: during boot, I get
scsi0: ahci
ata1: port is slow to respond, pls be patient
ata1: port failed to respond (30 sec)
ata1: soft reset failed (device not ready)
ata1: soft reset failed retrying in 5 secs
etc

after a while everything recovers and seems to work OK
afterwards, but still this seems to add about a minute or so
to the boot time.

I'm not sure how to test whether I get the speedup that you
mention.

Hope this report helps.


-- 
MST
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/